Skip to content

Conversation

@paulb777
Copy link
Member

The platform specifications cause build warnings in Xcode 12. They're not necessary since gtm-session-fetcher supports all versions supported by Xcode versions that support Swift Package Manager.

Details in firebase/firebase-ios-sdk#6449, https://forums.swift.org/t/minimum-ios-version-xcode-12-and-build-warnings/40224, and https://github.com/apple/swift-evolution/blob/master/proposals/0236-package-manager-platform-deployment-settings.md

Copy link
Member

@thomasvl thomasvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was gonna say that we need this to declare that we don't support Linux, but that never made it into the proposal. So since we don't provide a different min, I guess this is fine.

@thomasvl thomasvl merged commit 67ba34f into google:master Sep 14, 2020
@paulb777 paulb777 deleted the spm-warning-fix branch September 14, 2020 14:34
thomasvl added a commit to thomasvl/google-api-objectivec-client-for-rest that referenced this pull request Oct 26, 2020
thomasvl added a commit to google/google-api-objectivec-client-for-rest that referenced this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants