Remove instanceID dependency from Messaging #6103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceIDTokenInfo and FIRInstanceIDAPNSInfo class name
…ry layer of complexity
charlotteliang
requested review from
maksymmalyhin and
paulb777
and removed request for
maksymmalyhin
|
The previous PR (#6064) had a strange 'git rebase' conflicts problem today after I merged from master. I suspect it's something with the token branch. Will try to push to a new branch so all the changes are not lost and I will start from a new dev branch with smaller number of commits. Create this new one and @paulb777 can you approve again. Should be no difference. |
paulb777
approved these changes
Jul 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move checkin logic from IID to Messaging (FIRMessagingAuth* FIRMessagingCheckin*)
Move Token logic from IID to Messaging (FIRMessagingToken*, all the token operations files)
(The files above mostly copy over, rename and fix compiling errors and logic issues)
Merge MessagingCode and Utilities between IID and Messaging.
I have not added unit tests from IID yet to prevent this PR getting even bigger.
All IID code is under token/ folder.
FIRMessagingTokenManager serves as the central object that holds the values of token and checkin info. It is the communication between messaging and previous IID classes.
All the persistent storage path are kept the same to ensure IID still works with Messaging if users are still using InstanceID.
Kept all the communications between IID and Messaging in case users still use IID API to handle token and apns info. (APNS used to be in iid)
Tested with Messaging getToken and deleteToken API.
When token is updated from messaging side, need to add a new notification to notify IID to update its cache.
Tested interactions between Messaging Token API and IID Token API and FID API (this is blocked by previous task)
#no-changelog
Testing
API Changes
us make Firebase APIs better, please propose your change in a feature request so that we
can discuss it together.