Remove instanceID dependency from Messaging #6064
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceIDTokenInfo and FIRInstanceIDAPNSInfo class name
…ry layer of complexity
* Fix unguarded multithreaded access * Update changelog * fix typo in doc comments * fix nullability build error * Serialize via FIRAuthGlobalWorkQueue * remove unused code
paulb777
reviewed
Jul 20, 2020
| // Notify InstanceID that APNS Token has been set. | ||
| NSDictionary *userInfo = @{kFIRMessagingAPNSTokenType : @(type)}; | ||
| // TODO(chliang) This is sent to InstanceID in case users are still using the deprecated SDK. | ||
| // Should be safe to remove once InstanceID is removed. |
There was a problem hiding this comment.
Couldn't users be using InstanceID long after we remove it?
There was a problem hiding this comment.
No if we remove it completely from firebase-ios-sdk. if they use previous version of IID it's probably fine as messaging still kept those communications.
| completion:^(NSString *_Nullable FCMToken, NSError *_Nullable error) { | ||
| if (error) { | ||
| FIRMessagingLoggerError(kFIRMessagingMessageCodeMessaging012, | ||
| @"The unsubscription operation failed due to " |
There was a problem hiding this comment.
We will have to adjust integration test with it as well. The same as the subscription message. I can do it in a separate PR so we can merge in g3 to fix integration test as this PR might not be checked in to master for a while.
paulb777
approved these changes
Jul 20, 2020
* Fix potential strlen crash on NULL betaToken * Add CHANGELOG * restart CI
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token branch had a strange 'git rebase' conflicts problem today after I merged from master. Will try to push to a new branch (#6103) so all the changes are not lost and I will start from a new dev branch with smaller number of commits.
Please ignore this one.