Skip to content

M62 patch release: cherry pick Firebase Installations changes (#4683) #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2020
Merged

M62 patch release: cherry pick Firebase Installations changes (#4683) #4693

merged 3 commits into from
Jan 17, 2020

Conversation

@maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Jan 16, 2020 •
edited
Loading

@maksymmalyhin
Firebase Installations: validation of FIROptions parameters (#4683)
5e9f8dc 
* FIS: Throw exception on incomplete Firebase config.

* API docs updated.

* FirebaseInstallations bump minor version: 1.1.0

* Fix tests

* Text fixed

* Make exception message more informative

* Fix Remote Config tests.

* Tests updated to use GCMSenderID if projectID is not available.

* Use `GCMSenderID` when `projectID` is not available.

* ./scripts/style.sh

* Comments

* GCMSenderID and projectID validation updated.

* Comment

* FirebaseInstallations: version bump to 1.0.1.

* FIS changelog

* FirebaseInstallations: version bump to 1.1.0

* FIS and Core changelogs.

* Changelogs remove GCMSenderID

* Typo

* Typo

* fix link

* Revert Core changelog

* FIS changelog fix.
ryanwilson
ryanwilson approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for travis green :)

ryanwilson
ryanwilson approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-picks are good with me.

@maksymmalyhin
Copy link
Contributor Author

maksymmalyhin commented Jan 16, 2020

Messaging failure was fixed in #4689 but it is not a part of this patch release.

@maksymmalyhin maksymmalyhin merged commit 7843a32 into release-6.15.0-patch Jan 17, 2020
@maksymmalyhin maksymmalyhin deleted the mm/fis-validation-6.15.0-patch branch January 17, 2020 00:28
@firebase firebase locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees

No one assigned

Labels

api: installations api: remoteconfig cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maksymmalyhin @ryanwilson @googlebot @google-oss-bot