Skip to content

Conversation

@maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Jan 13, 2020

Fixes failures like this.

#no-changelog

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distantFuture nice! I learned something. Thanks!

@maksymmalyhin maksymmalyhin merged commit 71a001e into master Jan 13, 2020
@maksymmalyhin maksymmalyhin deleted the mm/fcm-tests branch January 13, 2020 19:01
maksymmalyhin added a commit that referenced this pull request Jan 17, 2020
…#4693)

* Firebase Installations: validation of FIROptions parameters (#4683)

* FIS: Throw exception on incomplete Firebase config.

* API docs updated.

* FirebaseInstallations bump minor version: 1.1.0

* Fix tests

* Text fixed

* Make exception message more informative

* Fix Remote Config tests.

* Tests updated to use GCMSenderID if projectID is not available.

* Use `GCMSenderID` when `projectID` is not available.

* ./scripts/style.sh

* Comments

* GCMSenderID and projectID validation updated.

* Comment

* FirebaseInstallations: version bump to 1.0.1.

* FIS changelog

* FirebaseInstallations: version bump to 1.1.0

* FIS and Core changelogs.

* Changelogs remove GCMSenderID

* Typo

* Typo

* fix link

* Revert Core changelog

* FIS changelog fix.

* Travis: Run tests on release-6.15.0-patch

* FCM: fix distant future date in the tests. (#4667)
@firebase firebase locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants