Reimplement #10068 in auth-swift after rebase #11005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ncooke3
approved these changes
Mar 24, 2023
|
Going to merge here. To fix the quickstart, There is still an additional issue getting Swift computed properties visible to ObjC. I'll work on that next. |
paulb777
added a commit
that referenced
this pull request
Mar 30, 2023
paulb777
added a commit
that referenced
this pull request
Apr 2, 2023
paulb777
added a commit
that referenced
this pull request
Apr 5, 2023
paulb777
added a commit
that referenced
this pull request
Apr 7, 2023
paulb777
added a commit
that referenced
this pull request
Apr 10, 2023
paulb777
added a commit
that referenced
this pull request
Apr 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement #10068 in auth-swift after rebase of master
Removes FIRAuthTests.m. It will need to be reimplemented from master after FIRAuth.m is eliminated.