Skip to content

Enable COUNT integration tests, now that backend support has rolled out #10299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2022
Merged

Enable COUNT integration tests, now that backend support has rolled out #10299

merged 1 commit into from
Oct 4, 2022

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Oct 3, 2022

Enable the integration tests for COUNT that were added in #10254 now that the RunAggregationQuery RPC has been fully rolled out.

#no-changelog

@dconeybe dconeybe self-assigned this Oct 3, 2022
@google-oss-bot
Copy link

google-oss-bot commented Oct 3, 2022

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 87.97% (a10bbca) to 87.94% (5321990) by -0.03%.

    FilenameBase (a10bbca)Merge (5321990)Diff
    leveldb_key.cc98.63%98.14%-0.49%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3wYePeqq9e.html

@dconeybe dconeybe requested a review from wu-hui October 3, 2022 19:47
@dconeybe dconeybe marked this pull request as ready for review October 3, 2022 19:48
@wu-hui wu-hui merged commit a15469e into master Oct 4, 2022
@wu-hui wu-hui deleted the dconeybe/CountIntegrationTestEnableInCI branch October 4, 2022 15:37
@firebase firebase locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dconeybe @google-oss-bot @wu-hui