Skip to content

Public count #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 28, 2022
Merged

Public count #10254

merged 4 commits into from
Sep 28, 2022

Conversation

@wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Sep 23, 2022

Reverts #10252

@wu-hui wu-hui requested a review from dconeybe September 23, 2022 17:51
@dconeybe dconeybe changed the title Revert "Revert "Public count"" Public count Sep 23, 2022
@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Sep 23, 2022
@google-oss-bot
Copy link

google-oss-bot commented Sep 23, 2022

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (65f6cfa)Merge (fe39b48)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vhZqoMmlYA.html

@google-oss-bot
Copy link

google-oss-bot commented Sep 23, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 87.93% (a6164a8) to 87.94% (ed2cb55) by +0.01%.

    FilenameBase (a6164a8)Merge (ed2cb55)Diff
    FIRAggregateQuery.mm89.29%91.89%+2.61%
    FIRAggregateQuerySnapshot.mm76.92%100.00%+23.08%
    leveldb_key.cc98.33%98.14%-0.20%
    leveldb_remote_document_cache.cc96.25%94.38%-1.88%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UaRNzqpWCK.html

@ehsannas ehsannas merged commit 4232ac1 into master Sep 28, 2022
@ehsannas ehsannas deleted the revert-10252-revert-10246-wuandy/PublicCount branch September 28, 2022 01:01
@dconeybe dconeybe mentioned this pull request Oct 3, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@wu-hui wu-hui

Labels

api: firestore public-api-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wu-hui @google-oss-bot @dconeybe @ehsannas