-
Notifications
You must be signed in to change notification settings - Fork 71
Allow selecting code style in Intellij plugin #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Thanks for your interest in palantir/palantir-java-format, @shitikanth! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
|
Any update on this? Not sure what the hold up is for such basic yet useful feature. |
|
@q3769-patientpoint Very few non-bot commits in the project in the past three months. Looks like not a very big priority within Palantir. 🤷 |
Did you sign the contributor license agreement as requested? |
Yup, signed on the same day I submitted the PR. Just waiting for a reviewer to approve afaict. |
Before this PR
Idea plugin users could not choose the code style (GOOGLE, PALANTIR vs AOSP) although this was allowed using the cli as well as the maven and gradle plugins.
After this PR
The plugin allows users to select between the three supported code styles.
Closes #903
Possible downsides?
None that I can think of.