Allow empty or missing begin #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The errors in the CI seems to be from the fact that the JADE language uses the same constructs as the PUG language described in #82 and more fully described in microsoft/vscode#65983. This causes the test to have fewer results than is expected, but I am not fully sure if the code is finding an empty 'canonicalTokens` element, or running out of elements. It looks like the test for JADE will need amended, as the expected test results are incorrect. |
|
#22 would appear to be the same issue, though its marked closed, I don't think it was ever remedied. |
|
👍 Thank you! |
|
Thanks guys, I am looking forward to the April release! |
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the other half of #82, by allowing a begin rule to be empty (or otherwise missing) as long as an end rule exists.
This PR was submitted separately so it can be considered separately.
I have only tested through the 'inspect' tool.