Skip to content

Conversation

@efriis
Copy link
Contributor

@efriis efriis commented Jul 17, 2024

xfailing some sql tests that do not currently work on sqlalchemy v1

#22207 was very much not sqlalchemy v1 compatible.

Moving forward, implementations should be compatible with both to pass CI

@vercel
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 9:52pm

@dosubot dosubot bot added size:S labels Jul 17, 2024
@dosubot dosubot bot added size:M and removed size:S labels Jul 19, 2024
Erick Friis added 5 commits July 19, 2024 14:12
@dosubot dosubot bot added size:L and removed size:M labels Jul 19, 2024
@efriis efriis enabled auto-merge (squash) July 19, 2024 21:49
@efriis efriis disabled auto-merge July 19, 2024 21:49
@efriis efriis enabled auto-merge (squash) July 19, 2024 21:54
@efriis efriis merged commit f4ee3c8 into master Jul 19, 2024
@efriis efriis deleted the erick/infra-add-min-version-testing-to-pr-test-flow branch July 19, 2024 22:03
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
xfailing some sql tests that do not currently work on sqlalchemy v1

langchain-ai#22207 was very much not sqlalchemy v1 compatible. 

Moving forward, implementations should be compatible with both to pass
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants