Optionally allow numeric over- and under-flows #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although JSON specification does not set any limits on how large (or small) JSON numeric values can be, JSONKit throws an error when it encounters numbers that are too large to represent on a given system. This is undesirable behavior when dealing with some web-service providers that may, for example, return very large TTL values (to represent non-expiring timestamps) or metrics that are very close to zero and could be easily represented as such. JKParseOptionTruncateNumbers is a parse option introduced here that, when set, causes parser to ignore overflow-related numeric errors. When this option is not set, the parser behaves in a normal way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although JSON specification does not set any limits on how large
(or small) JSON numeric values can be, JSONKit throws an error
when it encounters numbers that are too large to represent on a
given system. This is may be an undesirable behavior when dealing
with some web-service providers that may, for example, return very
large TTL values (to represent non-expiring timestamps) or metrics
that are very close to zero and could be easily represented as such.
JKParseOptionTruncateNumbers is a parse option introduced here that,
when set, causes parser to ignore overflow-related numeric errors.
When this option is not set, the parser behaves in a normal way.