fix(firestore): set firestore client language attribution to react-native #8738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SelaseKay
reviewed
Oct 30, 2025
packages/firestore/ios/RNFBFirestore/RNFBFirestoreClientLanguage.mm
Outdated
Show resolved
Hide resolved
SelaseKay
approved these changes
Oct 30, 2025
…test for some reason firebase-ios-sdk now returns the old session id even after you set a tight expiration time and definitely wait for it to expire, skipping for now. Android unaffected
mikehardy
force-pushed
the
@mikehardy/firestore-client-language
branch
from
0f1862a to
4892043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attribute firestore GRPC calls to react-native language source
Related issues
Inspired by similar PR in FlutterFire sister project from @SelaseKay -
Release Summary
also includes a trivial firebase-ios-sdk bump, both are conventional commits and will release correctly automatically with no further attention
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
gl-rnlanguage inclusion inx-goog-client-apiheader not directly tested but CI will show there is no regression in firestore functionality at minimumThink
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter