Skip to content

Conversation

@zifeitong
Copy link
Contributor

What does this PR do?

rope_config_validation() uses max_position_embeddings.

Fixes #40461.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: gpt_oss

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is correct, rope validation should be the last step. Thank you for submitting the fix @zifeitong ! 🫶

(action point for me: this issue went undetected in our tests; add a mixin test trying to initialize yarn with all config classes)

@gante
Copy link
Member

gante commented Aug 27, 2025

cc @ArthurZucker (merging as soon as flaky CI gets green)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@gante gante merged commit 75d6f17 into huggingface:main Aug 27, 2025
24 checks passed
@gante
Copy link
Member

gante commented Sep 2, 2025

PR enabling tests: #40630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'GptOssConfig' object has no attribute 'max_position_embeddings'

3 participants