Skip to content

Remove GeoPoint.toString() #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2018
Merged

Remove GeoPoint.toString() #401

merged 2 commits into from
Oct 17, 2018

Conversation

@schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Oct 17, 2018 •
edited
Loading

  • This is not in our Mobile API.
  • It's not in our TS types.
  • We don't have .toString in any other types.
  • The next release is already a breaking change.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2018
mikelehen
mikelehen approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@mikelehen mikelehen removed their assignment Oct 17, 2018
@schmidt-sebastian schmidt-sebastian merged commit 018c282 into master Oct 17, 2018
@schmidt-sebastian schmidt-sebastian mentioned this pull request Oct 18, 2018
Merged
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-removetostring branch November 2, 2018 19:10
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikelehen mikelehen mikelehen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@schmidt-sebastian schmidt-sebastian

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@schmidt-sebastian @mikelehen @googlebot