Lazy-load all GRPC dependencies #197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fork of #196 and addresses a performance issue on Google Cloud Functions. Firestore usage on GCF is often read-only - that is, they provide the payload for a DocumentSnapshot and use Firestore only to deserialize this payload. We don't need to initialize the networking stack unless the user ends up writing back to Firestore.
This PR lazy-loads v1beta1 and
@google-cloud/common.The PR also removes
@google-cloud/common-grpc(as this also pulls in the GRPC dependency). Unfortunately, this means that we no longer inherit from GrpcService. Is that a problem?Test code:
Before: 473 ms, After: 34ms on a fully beefed-up Macbook