Skip to content

fix: don't use String.format in Preconditions messages #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

fix: don't use String.format in Preconditions messages #2691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...e-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/BulkMutation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ public BulkMutation add(@Nonnull ByteString rowKey, @Nonnull Mutation mutation)
long mutationCount = mutation.getMutations().size();
Preconditions.checkArgument(
mutationCountSum + mutationCount <= MAX_MUTATION,
String.format(
"Too many mutations, got %s, limit is %s",
mutationCountSum + mutationCount, MAX_MUTATION));
"Too many mutations, got %s, limit is %s",
mutationCountSum + mutationCount,
MAX_MUTATION);
this.mutationCountSum += mutationCount;

builder.addEntries(
Expand Down
6 changes: 3 additions & 3 deletions ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/RowMutationEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,9 @@ public RowMutationEntry mergeToCell(
public MutateRowsRequest.Entry toProto() {
Preconditions.checkArgument(
mutation.getMutations().size() <= MAX_MUTATION,
String.format(
"Too many mutations, got %s, limit is %s",
mutation.getMutations().size(), MAX_MUTATION));
"Too many mutations, got %s, limit is %s",
mutation.getMutations().size(),
MAX_MUTATION);
return MutateRowsRequest.Entry.newBuilder()
.setRowKey(key)
.addAllMutations(mutation.getMutations())
Expand Down
Loading