fix: don't use String.format in Preconditions messages #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
steveniemitz
force-pushed
the
remove-string-formats
branch
from
5926cc3 to
fd9da65
Compare
steveniemitz
changed the title
mutianf
previously approved these changes
Oct 10, 2025
steveniemitz
force-pushed
the
remove-string-formats
branch
from
fd9da65 to
698e1f3
Compare
steveniemitz
force-pushed
the
remove-string-formats
branch
from
698e1f3 to
f093f4d
Compare
mutianf
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates unnecessary allocations/work in the common case where the precondition is met.