Skip to content

[Network] Resolve Xcode 15 Beta 4 runtime warning #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2023
Merged

[Network] Resolve Xcode 15 Beta 4 runtime warning #114

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b24143
[Network] Resolve Xcode 15 Beta 4 runtime warning
ncooke3 Jul 14, 2023
8324189
Re-work
ncooke3 Jul 18, 2023
72931b6
Review
ncooke3 Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion GoogleUtilities/Network/GULNetworkURLSession.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,15 @@ - (nullable NSString *)sessionIDFromAsyncPOSTRequest:(NSURLRequest *)request
session = [NSURLSession sessionWithConfiguration:_sessionConfig
delegate:self
delegateQueue:[NSOperationQueue mainQueue]];
postRequestTask = [session uploadTaskWithRequest:request fromData:request.HTTPBody];
// To avoid a runtime warning in Xcode 15 Beta 4, the given `URLRequest`
// should have a nil `HTTPBody`. To workaround this, the given `URLRequest`
// is copied and the `HTTPBody` data is removed.
NSData *givenRequestHTTPBody = [request.HTTPBody copy];
NSMutableURLRequest *requestWithoutHTTPBody = [request mutableCopy];
requestWithoutHTTPBody.HTTPBody = nil;

postRequestTask = [session uploadTaskWithRequest:requestWithoutHTTPBody
fromData:givenRequestHTTPBody];
}

if (!session || !postRequestTask) {
Expand Down