Skip to content

Conversation

@samedson
Copy link
Collaborator

@samedson samedson commented Apr 18, 2023

https://developer.apple.com/forums/thread/714876

  • Deprecated with no replacement in iOS 16.4.

Depends on: firebase/firebase-ios-sdk#11144

Currently FirebaseSessions is the only user of this API.

TODO

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change needs to wait until the next GoogleUtilities major release to avoid breaking existing installs depending on GoogleUtilities 7.x

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • GoogleUtilities-ios-unit-GoogleUtilities.framework

    Overall coverage changed from 0.62% (871d431) to 0.12% (6929e8b) by -0.50%.

    FilenameBase (871d431)Merge (6929e8b)Diff
    GULNetworkInfo.m23.86%0.00%-23.86%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SObIweX027.html

@samedson
Copy link
Collaborator Author

@paulb777 sounds good. Just added that to the list of tasks.

@paulb777 paulb777 added this to the GoogleUtilities 8.0.0 milestone Apr 19, 2023
@paulb777
Copy link
Member

Added to the 8.0.0 milestone

@ncooke3 ncooke3 changed the base branch from main to release-8.0 May 22, 2024 20:25
@ncooke3
Copy link
Member

ncooke3 commented May 22, 2024

Hi @samedson, I changed the base branch to merge into release-8.0 as we are now working on prepping for GUls v8. Is this PR ready for a final review?

@samedson
Copy link
Collaborator Author

@ncooke3 yes it is!

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup!

@samedson samedson merged commit af1ad2e into release-8.0 May 23, 2024
@samedson samedson deleted the ctcarrier-deprecated branch May 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants