add new error for disabled service, with test #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlazo
approved these changes
May 15, 2024
common/src/main/kotlin/com/google/ai/client/generativeai/common/APIController.kt
Outdated
Show resolved
Hide resolved
andrewheard
reviewed
May 15, 2024
common/src/test/resources/golden-files/unary/failure-service-disabled.json
Show resolved
Hide resolved
rlazo
reviewed
May 16, 2024
common/src/main/kotlin/com/google/ai/client/generativeai/common/APIController.kt
Outdated
Show resolved
Hide resolved
rlazo
requested changes
May 16, 2024
common/src/main/kotlin/com/google/ai/client/generativeai/common/APIController.kt
Outdated
Show resolved
Hide resolved
common/src/main/kotlin/com/google/ai/client/generativeai/common/APIController.kt
Outdated
Show resolved
Hide resolved
rlazo
previously approved these changes
May 21, 2024
andrewheard
approved these changes
May 21, 2024
|
We probably also want to match swift's error message |
|
The error message from the serverside contains the link to fix the issue, and is passed along to the customer |
rlazo
approved these changes
May 22, 2024
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
Co-authored-by: David Motsonashvili <davidmotson@google.com>
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
Co-authored-by: David Motsonashvili <davidmotson@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.