This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make no_lto in presubmit explicit in .ci.yaml #40254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyHillers
approved these changes
Mar 13, 2023
|
When this lands, we can remove the starlark code at https://cs.opensource.google/flutter/infra/+/main:config/lib/ci_yaml/ci_yaml.star;l=397-398?q=ci_yaml.star&ss=flutter%2Finfra |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently --no-lto is hardcoded in presubmit builds in the ci_yaml starlark file here https://cs.opensource.google/flutter/infra/+/main:config/lib/ci_yaml/ci_yaml.star;l=398?q=lto&ss=flutter%2Finfra:config%2F.
This PR shifts setting the property into the
.ci.yamlfile. Since in general we want LTO in prod builds, and no LTO in try builds, this PR sets theno_ltoproperty totruein theplatform_properties, then for each configuration setsno_ltotofalsein their respectivepostsubmit_properties. This would be less confusing if.ci.yamlsupported apresubmit_propertiesthat could be set once-and-for-all in theplatform_propertiescc @keyonghan