Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Nov 26, 2022

Triaging flutter/flutter#93257 I couldn't reproduce the issue. It looks like zero font size was fixed. I couldn't find a test for it, so adding a test in this PR.

@ditman
Copy link
Member

ditman commented Nov 29, 2022

@yjbanov I think you closed the wrong issue with this PR?

Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov
Copy link
Contributor Author

yjbanov commented Dec 4, 2022

@yjbanov I think you closed the wrong issue with this PR?

Whoops! Fixed.

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #37916 at sha 727ebbb

@yjbanov yjbanov force-pushed the test-zero-font-size branch from 727ebbb to 7ca1965 Compare December 6, 2022 00:24
@skia-gold
Copy link

Gold has detected about 2 new digest(s) on patchset 1.
View them at https://flutter-engine-gold.skia.org/cl/github/37916

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #37916 at sha 7ca1965

@skia-gold
Copy link

Gold has detected about 2 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/37916

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #37916 at sha a9ca8b2

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2022
@auto-submit auto-submit bot merged commit 9554754 into flutter:main Dec 6, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 6, 2022
…116620)

* 143977b53 Roll Skia from b63a254727f3 to 13e5241ce8b7 (6 revisions) (flutter/engine#38106)

* 9554754ac [web:canvaskit] test zero font size (flutter/engine#37916)

* 4f22c2789 Roll Skia from 13e5241ce8b7 to aea62b0970c3 (2 revisions) (flutter/engine#38107)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#116620)

* 143977b53 Roll Skia from b63a254727f3 to 13e5241ce8b7 (6 revisions) (flutter/engine#38106)

* 9554754ac [web:canvaskit] test zero font size (flutter/engine#37916)

* 4f22c2789 Roll Skia from 13e5241ce8b7 to aea62b0970c3 (2 revisions) (flutter/engine#38107)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#116620)

* 143977b53 Roll Skia from b63a254727f3 to 13e5241ce8b7 (6 revisions) (flutter/engine#38106)

* 9554754ac [web:canvaskit] test zero font size (flutter/engine#37916)

* 4f22c2789 Roll Skia from 13e5241ce8b7 to aea62b0970c3 (2 revisions) (flutter/engine#38107)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine will affect goldens

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants