Skip to content

Update quickstart for non-optional Codable #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2022
Merged

Update quickstart for non-optional Codable #1357

merged 2 commits into from
Mar 8, 2022

Conversation

@morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Mar 3, 2022 •
edited
Loading

See firebase/firebase-ios-sdk#9101, internal b/222563260.

This change will cause build failures before Firebase dependencies are updated to 8.13.0.

@morganchen12 morganchen12 requested a review from paulb777 March 3, 2022 23:33
paulb777
paulb777 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please update the Podfile and Podfile.lock as well and merge after 8.13.0 publishes.

@morganchen12 morganchen12 merged commit da9217b into master Mar 8, 2022
@morganchen12 morganchen12 deleted the morganchen12-patch-1 branch March 8, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@morganchen12 @paulb777