Skip to content

Ensure that dependent APIs are enabled during Backend creation flow. #6595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Ensure that dependent APIs are enabled during Backend creation flow. #6595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cf8efb
Ensure that depedent APIs are enabled during Backend creation flow.
taeold Dec 7, 2023
27387cb
Merge branch 'master' into dl-enable-dependent-apis
taeold Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/init/features/frameworks/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { API_VERSION } from "../../../gcp/frameworks";
import { FirebaseError } from "../../../error";
import { promptOnce } from "../../../prompt";
import { DEFAULT_REGION, ALLOWED_REGIONS } from "./constants";
import { ensure } from "../../../ensureApiEnabled";

const frameworksPollerOptions: Omit<poller.OperationPollerOptions, "operationResourceName"> = {
apiOrigin: frameworksOrigin,
Expand All @@ -24,6 +25,13 @@ const frameworksPollerOptions: Omit<poller.OperationPollerOptions, "operationRes
export async function doSetup(setup: any, projectId: string): Promise<void> {
setup.frameworks = {};

await Promise.all([
ensure(projectId, "cloudbuild.googleapis.com", "frameworks", true),
ensure(projectId, "secretmanager.googleapis.com", "frameworks", true),
ensure(projectId, "run.googleapis.com", "frameworks", true),
ensure(projectId, "artifactregistry.googleapis.com", "frameworks", true),
]);

logBullet("First we need a few details to create your backend.");

const location = await promptOnce({
Expand Down