Skip to content

Allow GCB repos to be reused in backend. #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Allow GCB repos to be reused in backend. #6579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c710e7
Allow GCB repos to be reused in backend.
taeold Dec 6, 2023
d78b143
Add test case.
taeold Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/init/features/frameworks/repo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,6 @@ export async function getOrCreateRepository(
let repo: gcb.Repository;
try {
repo = await gcb.getRepository(projectId, location, connectionId, repositoryId);
const repoSlug = extractRepoSlugFromUri(repo.remoteUri);
if (repoSlug) {
throw new FirebaseError(`${repoSlug} has already been linked.`);
}
} catch (err: unknown) {
if ((err as FirebaseError).status === 404) {
const op = await gcb.createRepository(
Expand Down
15 changes: 15 additions & 0 deletions src/test/init/frameworks/repo.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,21 @@ describe("composer", () => {
);
});

it("re-uses existing repository it already exists", async () => {
getConnectionStub.resolves(completeConn);
fetchLinkableRepositoriesStub.resolves(repos);
promptOnceStub.onFirstCall().resolves(repos.repositories[0].remoteUri);
getRepositoryStub.resolves(repos.repositories[0]);

const r = await repo.getOrCreateRepository(
projectId,
location,
connectionId,
repos.repositories[0].remoteUri
);
expect(r).to.be.deep.equal(repos.repositories[0]);
});

it("throws error if no linkable repositories are available", async () => {
getConnectionStub.resolves(pendingConn);
fetchLinkableRepositoriesStub.resolves({ repositories: [] });
Expand Down