Skip to content

Conversation

@yykamei
Copy link
Contributor

@yykamei yykamei commented Oct 11, 2023

Description

When starting a project with firebase init with GitHub Workflow, YAML files were configured with actions/checkout@v3 previously.

Now, actions/checkout@v4 has been released,
the template should also be updated to specify the latest version.

https://github.com/actions/checkout/releases/tag/v4.0.0

When starting a project with `firebase init` with GitHub Workflow,
YAML files were configured with `actions/checkout@v3` previously.

Now, `actions/checkout@v4` has been released,
the template should also be updated to specify the latest version.

https://github.com/actions/checkout/releases/tag/v4.0.0
@google-cla
Copy link

google-cla bot commented Oct 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@joehan joehan self-requested a review October 11, 2023 18:05
@joehan
Copy link
Contributor

joehan commented Oct 11, 2023

Thanks for the contribution! You need to sign the CLA before we can accept this. Otherwise, this LGTM. We're planning to run a major release soon to update the support Node versions from 16/18 to 18/20, so we'll include this in the release as well.

@yykamei
Copy link
Contributor Author

yykamei commented Oct 12, 2023

Thank you. I've signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf9379f) 54.53% compared to head (afba6a0) 54.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6441   +/-   ##
=======================================
  Coverage   54.53%   54.54%           
=======================================
  Files         347      347           
  Lines       23863    23863           
  Branches     4925     4925           
=======================================
+ Hits        13013    13015    +2     
+ Misses       9653     9652    -1     
+ Partials     1197     1196    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joehan joehan changed the base branch from master to next December 19, 2023 19:30
@joehan joehan merged commit d4e4b2d into firebase:next Dec 19, 2023
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yykamei yykamei deleted the patch-2 branch December 19, 2023 22:24
joehan added a commit that referenced this pull request Jan 2, 2024
* Use `checkout@v4` for Firebase Hosting Preview GitHub Workflow (#6441)

When starting a project with `firebase init` with GitHub Workflow,
YAML files were configured with `actions/checkout@v3` previously.

Now, `actions/checkout@v4` has been released,
the template should also be updated to specify the latest version.

https://github.com/actions/checkout/releases/tag/v4.0.0

Co-authored-by: joehan <joehanley@google.com>

* Support export in env parser (#6630)

* Support export in env parser

* use a noncapture group

---------

Co-authored-by: Yutaka Kamei <kamei@yykamei.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants