Skip to content

fix database:settings:get/set #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2020
Merged

fix database:settings:get/set #2811

merged 3 commits into from
Nov 11, 2020
+8 −1

Conversation

@bkendall
Copy link
Contributor

@bkendall bkendall commented Nov 11, 2020

Description

database:settings:get was returning an object instead of a string, so I've added a check to parse the returned object when necessary.

database:settings:set was failing when false was provided as the json PUT body because of a falsey check.

Scenarios Tested

all the combos of database:settings:get and :set

@bkendall bkendall requested a review from sarajmunjal November 11, 2020 22:18
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Nov 11, 2020
@bkendall bkendall merged commit d305caf into master Nov 11, 2020
@bkendall bkendall deleted the bk-db-get branch November 11, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sarajmunjal sarajmunjal sarajmunjal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bkendall @sarajmunjal