Skip to content

[Auth] Detect if IndexedDB returns an empty array in platform_browser/persistence. #7825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2023
Merged

[Auth] Detect if IndexedDB returns an empty array in platform_browser/persistence. #7825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2cb780
detect if indexdb returned a null array in platform_browser/persistence
DellaBitta Nov 29, 2023
8a369f5
ensure that keys from local cache are appended to poll requests
DellaBitta Nov 29, 2023
25fc976
changeset
DellaBitta Nov 29, 2023
e6ca30e
remove debug output
DellaBitta Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tiny-lobsters-own.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/auth': patch
---

Protection from enumerating an empty list in Auth's reading of IndexedDB results, as this causes errors in some macOS and iOS browser runtimes.
13 changes: 8 additions & 5 deletions packages/auth/src/platform_browser/persistence/indexed_db.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,13 +369,16 @@ class IndexedDBLocalPersistence implements InternalPersistence {

const keys = [];
const keysInResult = new Set();
for (const { fbase_key: key, value } of result) {
keysInResult.add(key);
if (JSON.stringify(this.localCache[key]) !== JSON.stringify(value)) {
this.notifyListeners(key, value as PersistenceValue);
keys.push(key);
if (result.length !== 0) {
for (const { fbase_key: key, value } of result) {
keysInResult.add(key);
if (JSON.stringify(this.localCache[key]) !== JSON.stringify(value)) {
this.notifyListeners(key, value as PersistenceValue);
keys.push(key);
}
}
}

for (const localKey of Object.keys(this.localCache)) {
if (this.localCache[localKey] && !keysInResult.has(localKey)) {
// Deleted
Expand Down