Compat Mode: Checking for "sessionStorage" reference crashes the app when chrome has "block third-party cookies" enabled

[rosostolato]

The same as #5618 but it's still broken for compat mode.

If customers enable the "block third-party cookies" feature under chrome settings, Chrome will throw an exception when you try to access the sessionStorage reference in window. To solve that, we should add a try/catch for all lines that reference sessionStorage and not only check if it's null.

firebase-js-sdk/packages/auth-compat/src/persistence.ts

Line 104 in cdada6c

if (!win?.sessionStorage) {

DOMException: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Unhandled Promise rejection: The user denied permission to access the database. ; Zone: <root> ; Task: Promise.then ; Value: The user denied permission to access the database.

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[hsubox76]

Seems to be used in Auth and Database

[sam-gc]

That PR I just linked should fix it in Auth, but I'll make sure to leave this open for database as well. @rosostolato I only see the issue when all cookies are disabled, not just third-party cookies. Which version of Chrome are you on?

[rosostolato]

@sam-gc I don't remember the version of Chrome I was using but I have just tested it now with the latest one and it seems it's not crashing anymore. I still see the database access error, but it's not breaking the app.

[sam-gc]

@rosostolato no problem, like I said it still happens for me when all cookies are disabled so there's at least an easy way to reproduce it 👍

[sam-gc]

I'm going to remove the api:auth tag for now; the fix for auth should be in the next release or the one after. We will keep this issue open for database