Skip to content

Fix RTDB race condition #9973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2022
Merged

Fix RTDB race condition #9973

merged 1 commit into from
Jul 1, 2022

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 30, 2022

Fix #7885

@paulb777 paulb777 requested review from jsdt and morganchen12 June 30, 2022 23:50
@google-oss-bot
Copy link

google-oss-bot commented Jun 30, 2022

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 57.04% (e2542c7) to 57.03% (48fd33c) by -0.01%.

    FilenameBase (e2542c7)Merge (48fd33c)Diff
    FIRDatabase.m14.93%15.76%+0.84%
    FSRWebSocket.m38.58%38.43%-0.15%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cg8TleaI0v.html

@paulb777 paulb777 merged commit 3862a56 into master Jul 1, 2022
@paulb777 paulb777 deleted the pb-fix-db-race branch July 1, 2022 21:38
@firebase firebase locked and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

@jsdt jsdt Awaiting requested review from jsdt

Assignees

No one assigned

Labels

api: database

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stable Crash: Database - reference(withPath:)

3 participants

@paulb777 @google-oss-bot @morganchen12