Skip to content

Conversation

@morganchen12
Copy link
Contributor

Fixes #8599.

@paulb777
Copy link
Member

paulb777 commented Apr 8, 2022

@paulb777
Copy link
Member

paulb777 commented Apr 8, 2022

Thanks Morgan. Is this the right fix versus making sure there is an error when nil is returned?

It seems that if an API claiming to return a FIRUser doesn't, it should provide an explanation as to why?

cc: @rosalyntan

@rosalyntan
Copy link
Member

Is this the right fix versus making sure there is an error when nil is returned?

It seems that if an API claiming to return a FIRUser doesn't, it should provide an explanation as to why?

I think this seems right to me -- nil can be returned in the success case, it just means there is no user stored in the access group. There is an example in our docs that highlights this case.

@paulb777
Copy link
Member

paulb777 commented Apr 8, 2022

Thanks for the explanation Rosalyn. That makes sense to me. :)

@morganchen12 morganchen12 merged commit c148216 into master Apr 11, 2022
@morganchen12 morganchen12 deleted the mc/auth branch April 11, 2022 19:03
@ryanwilson ryanwilson added this to the Firebase 9 milestone Apr 14, 2022
@firebase firebase locked and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obj-C to Swift auto translation Cocoa violation

5 participants