Skip to content

Conversation

@yakovmanshin
Copy link
Contributor

@yakovmanshin yakovmanshin commented Feb 25, 2022

[Closes #9275]

  • Specified InstallationsErrorDomain as the NS_SWIFT_NAME of FirebaseInstallations’s kFirebaseInstallationsErrorDomain

⚠️ Breaking Changes: Based on the issue, this PR should land in Firebase v9.

@paulb777 paulb777 added this to the Firebase 9 milestone Feb 25, 2022
@paulb777
Copy link
Member

Plan to merge once the v9 branch merges to master

* Specified `InstallationsErrorDomain` as the `NS_SWIFT_NAME` of FirebaseInstallations’s `kFirebaseInstallationsErrorDomain`
@yakovmanshin yakovmanshin changed the base branch from master to v9 March 18, 2022 19:11
@yakovmanshin
Copy link
Contributor Author

Plan to merge once the v9 branch merges to master

I updated this PR so it can be merged to v9.

FYI @paulb777

@paulb777 paulb777 merged commit 97b93d7 into firebase:v9 Mar 18, 2022
@firebase firebase locked and limited conversation to collaborators Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kFirebaseInstallationsErrorDomain missing NS_SWIFT_NAME

2 participants