Skip to content

pass appData for In-App Messaging's test message #9134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2022
Merged

pass appData for In-App Messaging's test message #9134

merged 3 commits into from
Jan 26, 2022

Conversation

@fumito-ito
Copy link
Contributor

@fumito-ito fumito-ito commented Dec 23, 2021

refs: #9126

FIRIAMFetchResponseParser is better not to ignore appData for test message. This PR fixes #9126 problems particaly but not completely.

@paulb777
Copy link
Member

paulb777 commented Dec 23, 2021

Thanks for the PR @fumito-ito! Many people are currently out, so it may be a few weeks before we can do a review.

@paulb777 paulb777 added the api: inappmessaging Firebase In App Messaging label Jan 12, 2022
@eldhosembabu
Copy link
Contributor

eldhosembabu commented Jan 25, 2022

hi @fumito-ito ,

Thanks for doing this fix and it looks good. But did you get any chance to check whether with this fix you were able to receive the data bundle for a test campaign. When I checked I was not able to receive the databundle and it seems like the back end is not sending it. Could you please confirm?

eldhosembabu
eldhosembabu approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@eldhosembabu eldhosembabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait till we test this changes before merging.

@paulb777
Copy link
Member

paulb777 commented Jan 25, 2022

@eldhosembabu You can merge it when ready.

@fumito-ito
Copy link
Contributor Author

fumito-ito commented Jan 26, 2022

hi @eldhosembabu,

Thanks for your review.

Thanks for doing this fix and it looks good. But did you get any chance to check whether with this fix you were able to receive the data bundle for a test campaign. When I checked I was not able to receive the databundle and it seems like the back end is not sending it. Could you please confirm?

#9126 is caused by both sdk and backend. This PR fixes only sdk problem. Could you report this problem to backend team ? Or to report this problem, could you let me know a backend team's public contact point If you have ?

@eldhosembabu
Copy link
Contributor

eldhosembabu commented Jan 26, 2022

I've already brought it to the backend team attention. Merging this PR as it looks good for the SDK side.

@eldhosembabu eldhosembabu merged commit 3784deb into firebase:master Jan 26, 2022
eldhosembabu added a commit that referenced this pull request Jan 26, 2022
@eldhosembabu
updating change log
2496c14 
updating change log wrt #9134
@eldhosembabu eldhosembabu mentioned this pull request Jan 26, 2022
Merged
eldhosembabu added a commit that referenced this pull request Jan 31, 2022
@eldhosembabu
updating change log (#9263)
114a5b8 
updating change log wrt #9134
leotianlizhan pushed a commit that referenced this pull request Feb 1, 2022
@fumito-ito @leotianlizhan
pass appData for In-App Messaging's test message (#9134)
d88da00 
* add test to check appData parsing

* parse appData for test message

* fix by formatter
leotianlizhan pushed a commit that referenced this pull request Feb 1, 2022
@eldhosembabu @leotianlizhan
updating change log (#9263)
f97e0d9 
updating change log wrt #9134
@firebase firebase locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eldhosembabu eldhosembabu eldhosembabu approved these changes

Assignees

@eldhosembabu eldhosembabu

Labels

api: inappmessaging Firebase In App Messaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In-App Messaging's test message does not include appData in response (and also not in InAppMessagingDisplayMessage )

3 participants

@fumito-ito @paulb777 @eldhosembabu