Skip to content

Fix RTDB crash from race #9123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2021
Merged

Fix RTDB crash from race #9123

merged 2 commits into from
Dec 22, 2021

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Dec 21, 2021

Fix #9096

@paulb777 paulb777 added this to the 8.11.0 - M110 milestone Dec 21, 2021
ncooke3
ncooke3 reviewed Dec 21, 2021
View reviewed changes
@google-oss-bot
Copy link

google-oss-bot commented Dec 22, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    SDK overall coverage changed from 56.63% (55717f4) to 56.65% (332d922) by +0.02%.

    Filename Base (55717f4) Head (332d922) Diff
    FSRWebSocket.m 38.73% 38.88% +0.15%
    FUtilities.m 73.71% 74.01% +0.30%

Test Logs

@paulb777 paulb777 merged commit 00625a6 into master Dec 22, 2021
@paulb777 paulb777 deleted the pb-rtdb-race branch December 22, 2021 16:58
Pattio pushed a commit to Pattio/firebase-ios-sdk that referenced this pull request Dec 22, 2021
@paulb777 @Pattio
Fix RTDB crash from race (firebase#9123)
bf57625
granluo pushed a commit that referenced this pull request Dec 29, 2021
@paulb777 @granluo
Fix RTDB crash from race (#9123)
8ff5a04
@firebase firebase locked and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ncooke3 ncooke3 ncooke3 left review comments

+1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@paulb777 paulb777

Labels

api: database

Projects

None yet

Milestone

8.11.0 - M110

Development

Successfully merging this pull request may close these issues.

Intermittent crash in FUtilities.intForString

4 participants

@paulb777 @google-oss-bot @schmidt-sebastian @ncooke3