Skip to content

Fix Analytics SwiftPM platform availability. #9032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 30, 2021
Merged

Fix Analytics SwiftPM platform availability. #9032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d400fc
Fix Analytics SwiftPM platform availability.
ryanwilson Nov 30, 2021
a68f10a
Clearer comment about availability
ryanwilson Nov 30, 2021
a2ef0b5
Changelog
ryanwilson Nov 30, 2021
475c993
Review changes
ryanwilson Nov 30, 2021
17f5bb7
Added a missing word in CHANGELOG
ryanwilson Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/spm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
strategy:
matrix:
target: [tvOS, macOS, catalyst]
# Full set of Firebase-Package tests only run on iOS because of Analytics.
# Full set of Firebase-Package tests only run on iOS.
steps:
- uses: actions/checkout@v2
- name: Initialize xcodebuild
Expand Down
4 changes: 4 additions & 0 deletions FirebaseCore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Firebase 8.10.1
- [fixed] Fixed platform availability checks in Swift Package Manager that may prevent code
completion for Analytics APIs on macOS and tvOS. (#9032)

# Firebase 8.10.0
- [added] Firebase now includes community supported Combine publishers. More details can be found
[here](https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseCombineSwift/README.md). (#7295)
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ let package = Package(
.target(
name: "FirebaseAnalyticsTarget",
dependencies: [.target(name: "FirebaseAnalyticsWrapper",
condition: .when(platforms: [.iOS]))],
condition: .when(platforms: [.iOS, .macOS, .tvOS]))],
path: "SwiftPM-PlatformExclude/FirebaseAnalyticsWrap"
),

Expand Down
9 changes: 4 additions & 5 deletions SwiftPackageManager.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ Prior to version 8.0.0 (starting with version 6.31.0) support was in Beta.

## Limitations

- Analytics is only supported for iOS and cannot be used in apps that support other platforms.
- watchOS support is available for ABTesting, Auth, Crashlytics, Messaging, Realtime Database,
RemoteConfig, and Storage.
- Product availability varies by platform. See [the chart on this page](https://firebase.google.com/docs/ios/learn-more#firebase_library_support_by_platform)
for information on product availabilty for each platform.

## Installation

Expand All @@ -36,7 +35,7 @@ Search for the Firebase Apple SDK using the repo's URL:
https://github.com/firebase/firebase-ios-sdk.git
```

Next, set the **Dependency Rule** to be `Up to Next Major Version` and specify `8.0.0` as the lower bound.
Next, set the **Dependency Rule** to be `Up to Next Major Version` and specify `8.10.0` as the lower bound.

Then, select **Add Package**.

Expand Down Expand Up @@ -81,7 +80,7 @@ dependencies: [
.package(
name: "Firebase",
url: "https://github.com/firebase/firebase-ios-sdk.git",
.upToNextMajor(from: "8.0.0")
.upToNextMajor(from: "8.10.0")
),

// Any other dependencies you have...
Expand Down