Skip to content

Public Functions Swift API build test coverage #8960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2021
Merged

Public Functions Swift API build test coverage #8960

merged 1 commit into from
Nov 12, 2021

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 12, 2021

  • Add build test coverage for Functions Public API surface not included in integration tests
  • Remove no longer necessary clang-format directive

@google-cla google-cla bot added the cla: yes label Nov 12, 2021
@google-oss-bot
Copy link

google-oss-bot commented Nov 12, 2021

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 enabled auto-merge (squash) November 12, 2021 16:50
@paulb777 paulb777 merged commit 10f4285 into master Nov 12, 2021
@paulb777 paulb777 deleted the pb-func-api-coverage branch November 12, 2021 17:17
@paulb777 paulb777 mentioned this pull request Nov 13, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: functions cla: yes public-api-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulb777 @google-oss-bot @maksymmalyhin