Skip to content

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 11, 2021

  • Add Async/await tests for Functions
  • Add commented out CocoaPods testspecs for Functions Swift integration tests
  • Add watchos to pod lib lint CI

I initially thought that CocoaPods was necessary to test async/await because of the global SPM minimum os version, but whether or not async/await tests get run is enabled by the test target's device.

Fix #8955 - a combine test build issue introduced in #8957

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Nov 12, 2021

Coverage Report

Affected SDKs

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    SDK overall coverage changed from 56.63% (f023aa5) to 56.79% (e0d69a0) by +0.16%.

    Filename Base (f023aa5) Head (e0d69a0) Diff
    FSRWebSocket.m 38.73% 40.82% +2.10%

Test Logs

Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice, thank you Paul!

@paulb777 paulb777 merged commit d1bb76f into master Nov 12, 2021
@paulb777 paulb777 deleted the pb-func-async branch November 12, 2021 16:21
@firebase firebase locked and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly Testing Report

3 participants