Skip to content

Conversation

@visumickey
Copy link
Contributor

@visumickey visumickey commented Nov 3, 2021

Fixes #8691

FPRSessionDetails contains the details about the current session. Whenever a trace is created, they take a copy of the session. But the session copy was not taking in the sessionStartTime which could lead to a situation where a check on the session expiration duration could cause a crash. The fix is to make sure the copy contains the same sessionStart time as the original session details object.

@google-oss-bot
Copy link

google-oss-bot commented Nov 3, 2021

Coverage Report

Affected SDKs

  • FirebasePerformance-iOS-FirebasePerformance.framework

    SDK overall coverage changed from 91.86% (9d998a7) to 91.86% (5fe94c3) by +0.00%.

    Filename Base (9d998a7) Head (5fe94c3) Diff
    FPRSessionDetails.m 92.59% 92.86% +0.26%

Test Logs

@paulb777
Copy link
Member

paulb777 commented Nov 3, 2021

Thanks. Fix trailing whitespace issue please.

Copy link
Contributor

@leotianlizhan leotianlizhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@visumickey visumickey merged commit 4deab9c into master Nov 3, 2021
@visumickey visumickey deleted the perfReturnSessionLengthReturnType branch November 3, 2021 19:53
@firebase firebase locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FPRSessionDetails: Attempted to dereference garbage pointer

5 participants