Skip to content

Cherry-pick FDL fix to 8.9.0 #8867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2021
Merged

Cherry-pick FDL fix to 8.9.0 #8867

merged 2 commits into from
Oct 26, 2021

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Oct 26, 2021

Cherry-pick #8866
Update Changelog

@google-cla google-cla bot added the cla: yes label Oct 26, 2021
@paulb777 paulb777 requested a review from morganchen12 October 26, 2021 19:19
@paulb777 paulb777 changed the base branch from master to release-8.9 October 26, 2021 19:19
@paulb777 paulb777 changed the title Cherry-pick FDK fix to 8.9.0 Cherry-pick FDL fix to 8.9.0 Oct 26, 2021
@google-oss-bot
Copy link

google-oss-bot commented Oct 26, 2021

Binary Size Report

Affected SDKs

  • FirebaseDynamicLinks

    Type Base (cdb57e1) Head (dd0ee8c) Diff
    CocoaPods ? 403 kB ? (?)

Test Logs

@google-oss-bot
Copy link

google-oss-bot commented Oct 26, 2021

Coverage Report

Affected SDKs

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    SDK overall coverage changed from ? (cdb57e1) to 60.35% (dd0ee8c) by ?.

    Click to show coverage changes in 15 files.
    Filename Base (cdb57e1) Head (dd0ee8c) Diff
    FDLDeviceHeuristicsHelper.m ? 0.00% ?
    FDLLogging.m ? 58.62% ?
    FDLURLComponents.m ? 81.95% ?
    FDLUtilities.m ? 72.96% ?
    FIRDLDefaultRetrievalProcessV2.m ? 14.04% ?
    FIRDLJavaScriptExecutor.m ? 23.26% ?
    FIRDLRetrievalProcessFactory.m ? 100.00% ?
    FIRDLRetrievalProcessResult.m ? 100.00% ?
    FIRDLScionLogging.m ? 100.00% ?
    FIRDynamicLink.m ? 77.78% ?
    FIRDynamicLinkComponentsKeyProvider.m ? 66.67% ?
    FIRDynamicLinkNetworking.m ? 44.10% ?
    FIRDynamicLinks.m ? 69.10% ?
    GINArgument.m ? 0.00% ?
    GINInvocation.m ? 0.00% ?

Test Logs

@paulb777 paulb777 merged commit 2064534 into release-8.9 Oct 26, 2021
@paulb777 paulb777 deleted the pb-cp-8866 branch October 26, 2021 19:31
@firebase firebase locked and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eldhosembabu eldhosembabu eldhosembabu approved these changes

@ncooke3 ncooke3 Awaiting requested review from ncooke3

@morganchen12 morganchen12 Awaiting requested review from morganchen12

Assignees

No one assigned

Labels

api: dynamiclinks cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulb777 @google-oss-bot @eldhosembabu