Skip to content

Persist schema version 7 #8850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2021
Merged

Persist schema version 7 #8850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f74aa19
Persist schema version 7
schmidt-sebastian Oct 21, 2021
f0d52ca
Update CHANGELOG.md
schmidt-sebastian Oct 21, 2021
614eeae
Update CHANGELOG.md
schmidt-sebastian Oct 22, 2021
964531d
Update CHANGELOG.md
schmidt-sebastian Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
- [added] Added support for Firebase AppCheck.
- [fixed] Fix a crash if `[FIRTransaction getDocument]` was called after
`[FIRFirestore terminateWithCompletion]` (#8760).
- [fixed] Fixed a performance issue due to repeated schema migrations
at app startup (#8791).

# v8.6.0
- [changed] Internal refactor to improve serialization performance.
Expand Down
1 change: 1 addition & 0 deletions Firestore/core/src/local/leveldb_migrations.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ void RewriteTargetsCanonicalIds(leveldb::DB* db,
transaction.Put(new_key, empty_buffer);
}

SaveVersion(7, &transaction);
transaction.Commit();
}

Expand Down