Skip to content

[Dynamic Links] Reduce memory stress on WebKit API #8847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2021
Merged

[Dynamic Links] Reduce memory stress on WebKit API #8847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bb7b08
Attempt to fix #8655
ncooke3 Oct 21, 2021
156d8c4
Update CHANGELOG
ncooke3 Oct 21, 2021
9684af2
Update CHANGELOG 2
ncooke3 Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FirebaseDynamicLinks/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# v8.9.0
- [fixed] Fixed Shortlink regression involving underscores and dashes introduced in 8.8.0. (#8786)
- [fixed] Reduce memory stress on `WebKit` API. #8847

# v8.8.0
- [fixed] Firebase dynamic links with custom domain will only work if the custom domain has a trailing '/'. (#7087)
Expand Down
5 changes: 1 addition & 4 deletions FirebaseDynamicLinks/Sources/FIRDLDefaultRetrievalProcessV2.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,7 @@ - (void)fetchLocaleFromWebView {
if (_jsExecutor) {
return;
}
NSString *jsString = @"window.generateFingerprint=function(){try{var "
@"languageCode=navigator.languages?navigator.languages[0]:navigator."
@"language;return languageCode;}catch(b){return"
"}};";
NSString *jsString = @"window.generateFingerprint=()=>navigator.language||''";
_jsExecutor = [[FIRDLJavaScriptExecutor alloc] initWithDelegate:self script:jsString];
}

Expand Down