App Check: error handling with backoff #8794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymmalyhin
changed the title
ncooke3
approved these changes
Oct 13, 2021
FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckBackoffWrapperTests.m
Outdated
Show resolved
Hide resolved
|
@ncooke3 thank you for the review! |
ncooke3
approved these changes
Oct 13, 2021
maksymmalyhin
added a commit
that referenced
this pull request
Oct 13, 2021
* AppCheck: backoff wrapper implementation draft (#8748) * FIRAppCheckBackoffWrapper draft * style * FIRAppCheckBackoffWrapper implementation draft * FIRAppCheckBackoffWrapperTests * 1d backoff implementation * Fix tests * WIP FIRAppCheckBackoffWrapperFake * FIRAppCheckBackoffWrapperFake implementation * FIRDeviceCheckProviderTests + backoff * TODOs * rename * Docs, typos, names and minor refactoring * App Check: error handling with backoff (#8794) * Exponential backoff with jitter * modify random to arc4random_uniform * Error handling WIP * Default backoff strategy for backend errors * Default error handler implementation and tests * Exponential backoff tests and fixes * Exponential becoff recovery tests * style * App Attest backoff integration and tests * More tests and style * FIRDeviceCheckProviderTests: default error handler tests * test fixes * FIRAppAttestProviderTests: backoff error handler tests * Providers tests: test backoff case * Better API docs * Remove `resetBackoff` * More docs and comment fixes * FIRAppAttestProviderTests fixes and cleanup * Higlight 503 error * comment fix * Changelog * More details in changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalizes implementation of b/195582486.
#no-changelog Changelog will be updated in the PR to master.