Skip to content

[AppCheck] Add support for bundle ID-based API Key Restrictions #8678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2021
Merged

[AppCheck] Add support for bundle ID-based API Key Restrictions #8678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d16eb8f
Add X-Ios-Bundle-Identifier to AC SDK
ncooke3 Sep 21, 2021
588d13e
Update CHANGELOG
ncooke3 Sep 21, 2021
d4ec94c
Update CHANGELOG 2
ncooke3 Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions FirebaseAppCheck/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# v8.8.0 -- M105
- [added] Add support for bundle ID-based API Key Restrictions (#8678)

# v8.6.0 -- M102
- [changed] Documented unsupported platforms (#8493).

Expand Down
4 changes: 4 additions & 0 deletions FirebaseAppCheck/Sources/Core/APIService/FIRAppCheckAPIService.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
static NSString *const kHeartbeatKey = @"X-firebase-client-log-type";
static NSString *const kHeartbeatStorageTag = @"fire-app-check";
static NSString *const kUserAgentKey = @"X-firebase-client";
static NSString *const kBundleIdKey = @"X-Ios-Bundle-Identifier";

static NSString *const kDefaultBaseURL = @"https://firebaseappcheck.googleapis.com/v1beta";

Expand Down Expand Up @@ -117,6 +118,9 @@ - (instancetype)initWithURLSession:(NSURLSession *)session
.stringValue
forHTTPHeaderField:kHeartbeatKey];

[request setValue:[[NSBundle mainBundle] bundleIdentifier]
forHTTPHeaderField:kBundleIdKey];

[additionalHeaders
enumerateKeysAndObjectsUsingBlock:^(NSString *_Nonnull key, NSString *_Nonnull obj,
BOOL *_Nonnull stop) {
Expand Down
3 changes: 3 additions & 0 deletions FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckAPIServiceTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ - (void)testDataRequestSuccess {

XCTAssertEqualObjects(request.allHTTPHeaderFields[@"X-Goog-Api-Key"], self.APIKey);

XCTAssertEqualObjects(request.allHTTPHeaderFields[@"X-Ios-Bundle-Identifier"],
[[NSBundle mainBundle] bundleIdentifier]);

XCTAssertEqualObjects(request.allHTTPHeaderFields[@"header1"], @"value1");

XCTAssertEqualObjects(request.HTTPMethod, @"POST");
Expand Down