[FDL] Refactoring and fixing url validation #8672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
|
Binary Size ReportAffected SDKsTest Logs
|
eldhosembabu
requested review from
paulb777 and
ryanwilson
and removed request for
paulb777
ryanwilson
reviewed
Sep 21, 2021
Corrected TYPO added more test inputs.
ryanwilson
approved these changes
Sep 22, 2021
|
Checked on xCode 13 and it is working. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FDL] Refactoring and fixing url validation
Refactored the existing code to use Regex to validate FDL URL formats.
Added checks to make sure the 'link' query param is having an http/https prefix input.
== This is going to be breaking the existing SDK's unintended behavior to support links with non http/https content. The existing SDK was constructing the Dynamic link eventhough the backend response to resolve the link is not successfull.
Added support for URL(s) with Query string starting with '?' alone. Previously it was supporting '/?' formats only. This fixes 177469304: Firebase dynamic links with custom domain will only work if the custom domai has a trailing '/' #7087
Added more test cases to be in sync with FDL backend validation.
Removed invalid test inputs and corrected few test cases to make the input in proper format.