Skip to content

Prevent firelog from logging invalid data #8443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2021
Merged

Prevent firelog from logging invalid data #8443

merged 3 commits into from
Jul 28, 2021

Conversation

@charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Jul 27, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Jul 27, 2021
@google-oss-bot
Copy link

google-oss-bot commented Jul 27, 2021

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Jul 27, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    SDK overall coverage changed from 64.53% (ecc7d6d) to 64.60% (b0e3072) by +0.07%.

    Filename Base (ecc7d6d) Head (b0e3072) Diff
    FIRMessagingCheckinService.m 89.80% 91.76% +1.96%
    FIRMessagingExtensionHelper.m 85.91% 83.47% -2.44%

Test Logs

@charlotteliang charlotteliang requested a review from paulb777 July 27, 2021 23:38
maksymmalyhin
maksymmalyhin approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple minor comments

@maksymmalyhin maksymmalyhin added this to the 8.5.0 - M101 milestone Jul 27, 2021
@charlotteliang charlotteliang merged commit 7fc7325 into master Jul 28, 2021
@charlotteliang charlotteliang deleted the chen-spm-test branch July 28, 2021 00:35
maksymmalyhin added a commit that referenced this pull request Jul 29, 2021
@maksymmalyhin
Revert "Prevent firelog from logging invalid data (#8443)"
f7ab4d1 
This reverts commit 7fc7325.
@maksymmalyhin maksymmalyhin mentioned this pull request Jul 29, 2021
Merged
maksymmalyhin added a commit that referenced this pull request Jul 29, 2021
@maksymmalyhin
Revert "Adding a new API that allows iOS users to log notification de…
b8e974d 
…livery signal that exports to BigQuery." (#8458)

* Revert "Prevent firelog from logging invalid data (#8443)"

This reverts commit 7fc7325.

* Revert "Update changelog (#8440)"

This reverts commit ecc7d6d.

* Revert " Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. (#6181)"

This reverts commit ce87d25.
@firebase firebase locked and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@paulb777 paulb777 Awaiting requested review from paulb777

+1 more reviewer

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: messaging cla: yes

Projects

None yet

Milestone

8.5.0 - M101

Development

Successfully merging this pull request may close these issues.

3 participants

@charlotteliang @google-oss-bot @maksymmalyhin