Skip to content

Better analyze fix #8287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2021
Merged

Better analyze fix #8287

merged 2 commits into from
Jun 23, 2021

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 22, 2021

Better fix than #8208 to fix analyzer and still allow nil errorPtr's

@google-cla google-cla bot added the cla: yes label Jun 22, 2021
@google-oss-bot
Copy link

google-oss-bot commented Jun 22, 2021

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Jun 22, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    SDK overall coverage changed from 75.58% (5ac44b8) to 57.12% (bd9f2f5) by -18.46%.

    Filename Base (5ac44b8) Head (bd9f2f5) Diff
    FDLUtilities.m 90.15% 73.48% -16.67%
    FIRDLDefaultRetrievalProcessV2.m 72.92% 0.00% -72.92%
    FIRDLJavaScriptExecutor.m 82.48% 0.00% -82.48%
    FIRDLRetrievalProcessFactory.m 100.00% 0.00% -100.00%
    FIRDynamicLinkNetworking.m 80.89% 43.96% -36.93%
    FIRDynamicLinks.m 69.84% 67.94% -1.90%

Test Logs

ryanwilson
ryanwilson approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulb777 paulb777 merged commit c5541b7 into master Jun 23, 2021
@paulb777 paulb777 deleted the pb-dl2 branch June 23, 2021 18:30
@firebase firebase locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ryanwilson ryanwilson ryanwilson approved these changes

@eldhosembabu eldhosembabu Awaiting requested review from eldhosembabu

Assignees

No one assigned

Labels

api: dynamiclinks cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulb777 @google-oss-bot @ryanwilson