Skip to content

Fix analyze issue introduced in Xcode 12.5 #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Fix analyze issue introduced in Xcode 12.5 #8209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .swiftpm/xcode/xcshareddata/xcschemes/ABTestingUnit.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "NO"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "ABTestingUnit"
BuildableName = "ABTestingUnit"
BlueprintName = "ABTestingUnit"
ReferencedContainer = "container:">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
buildConfiguration = "Debug"
Expand Down
3 changes: 3 additions & 0 deletions FirebaseABTesting/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# v8.2.0
- [fixed] Fixed analyze issue introduced in Xcode 12.5. (#8209)

# v7.7.0
- [added] Added community support for watchOS. ABTesting can now build on watchOS, but some functions might not work yet. (#7481)

Expand Down
2 changes: 1 addition & 1 deletion FirebaseABTesting/Sources/ABTExperimentPayload.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ + (NSDateFormatter *)experimentStartTimeFormatter {
return dateFormatter;
}

+ (instancetype)parseFromData:(NSData *)data {
+ (nullable instancetype)parseFromData:(NSData *)data {
NSError *error;
NSDictionary *experimentDictionary =
[NSJSONSerialization JSONObjectWithData:data
Expand Down
2 changes: 1 addition & 1 deletion FirebaseABTesting/Sources/Private/ABTExperimentPayload.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ typedef NS_ENUM(int32_t, ABTExperimentPayloadExperimentOverflowPolicy) {

/// Parses an ABTExperimentPayload directly from JSON data.
/// @param data JSON object as NSData. Must be reconstructible as an NSDictionary<NSString* , id>.
+ (instancetype)parseFromData:(NSData *)data;
+ (nullable instancetype)parseFromData:(NSData *)data;

/// Initializes an ABTExperimentPayload from a dictionary with experiment metadata.
- (instancetype)initWithDictionary:(NSDictionary<NSString *, id> *)dictionary
Expand Down