Skip to content

Fixed analyze issue introduced in Xcode 12.5 #8208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Fixed analyze issue introduced in Xcode 12.5 #8208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bae62a
Fixed analyze issue introduced in Xcode 12.5
paulb777 Jun 7, 2021
85bc6b5
Better fix
paulb777 Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions FirebaseDynamicLinks/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# v8.2.0
- [fixed] Fixed analyze issue introduced in Xcode 12.5. (#8208)

# v8.0.0
- [fixed] Fixed crashes on simulators targeting below iOS14 on Apple Silicon. (#7989)

Expand Down
5 changes: 3 additions & 2 deletions FirebaseDynamicLinks/Sources/FIRDynamicLinkNetworking.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,9 @@ - (void)retrievePendingDynamicLinkWithIOSVersion:(NSString *)IOSVersion
requestBody[@"uniqueMatchLinkToCheck"] = uniqueMatchLinkToCheck.absoluteString;
}

FIRDLNetworkingParserBlock responseParserBlock = ^NSDictionary *_Nullable(
NSString *requestURLString, NSData *data, NSString **matchMessagePtr, NSError **errorPtr) {
FIRDLNetworkingParserBlock responseParserBlock =
^NSDictionary *_Nullable(NSString *requestURLString, NSData *data, NSString **matchMessagePtr,
NSError **_Nonnull errorPtr) {
NSError *serializationError;
NSDictionary *result = [NSJSONSerialization JSONObjectWithData:data
options:0
Expand Down