Skip to content

Ensure sound is assigned with right type #8203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 15, 2021
Merged

Ensure sound is assigned with right type #8203

merged 9 commits into from
Jun 15, 2021

Conversation

@charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Jun 6, 2021

This fix #8172.

@google-cla google-cla bot added the cla: yes label Jun 6, 2021
@google-oss-bot
Copy link

google-oss-bot commented Jun 6, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    SDK overall coverage changed from ? (7a0679d) to 14.88% (67e882d) by ?.

    Click to show coverage changes in 29 files.
    Filename Base (7a0679d) Head (67e882d) Diff
    FIRMessaging.m ? 2.91% ?
    FIRMessagingAPNSInfo.m ? 0.00% ?
    FIRMessagingAnalytics.m ? 0.00% ?
    FIRMessagingAuthKeychain.m ? 38.07% ?
    FIRMessagingAuthService.m ? 3.77% ?
    FIRMessagingBackupExcludedPlist.m ? 80.82% ?
    FIRMessagingCheckinPreferences.m ? 60.91% ?
    FIRMessagingCheckinService.m ? 6.27% ?
    FIRMessagingCheckinStore.m ? 70.47% ?
    FIRMessagingContextManagerService.m ? 0.00% ?
    FIRMessagingExtensionHelper.m ? 0.00% ?
    FIRMessagingKeychain.m ? 32.06% ?
    FIRMessagingLogger.m ? 60.38% ?
    FIRMessagingPendingTopicsList.m ? 0.00% ?
    FIRMessagingPersistentSyncMessage.m ? 0.00% ?
    FIRMessagingPubSub.m ? 0.00% ?
    FIRMessagingRemoteNotificationsProxy.m ? 0.00% ?
    FIRMessagingRmqManager.m ? 0.00% ?
    FIRMessagingSyncMessageManager.m ? 0.00% ?
    FIRMessagingTokenDeleteOperation.m ? 0.00% ?
    FIRMessagingTokenFetchOperation.m ? 75.32% ?
    FIRMessagingTokenInfo.m ? 41.06% ?
    FIRMessagingTokenManager.m ? 0.00% ?
    FIRMessagingTokenOperation.m ? 95.57% ?
    FIRMessagingTokenStore.m ? 68.42% ?
    FIRMessagingTopicOperation.m ? 0.00% ?
    FIRMessagingUtilities.m ? 54.15% ?
    NSDictionary+FIRMessaging.m ? 0.00% ?
    NSError+FIRMessaging.m ? 100.00% ?

Test Logs

maksymmalyhin
maksymmalyhin approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI green, a couple nits.

paulb777
paulb777 approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when comments are resolved

@charlotteliang charlotteliang merged commit 62538d7 into master Jun 15, 2021
@charlotteliang charlotteliang deleted the chen-fm-sound branch June 15, 2021 19:32
@firebase firebase locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@paulb777 paulb777 paulb777 approved these changes

+1 more reviewer

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: messaging cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scheduled notifications by the recipient's time zone do not work

4 participants

@charlotteliang @google-oss-bot @paulb777 @maksymmalyhin